fix(ci): only exec-smoke host-native binary in release rehearsal - #21
Merged
Conversation
The rehearsal's smoke step executed every matrix binary directly on the runner, but cross-compiled targets can't run there (aarch64 Linux on an x86_64 host → Exec format error). The real release smokes exactly one target (release.yml's install.sh smoke on ubuntu), so mirror that: exec-smoke only the linux x86_64 binary and validate every other target's artifact via magic bytes (ELF/Mach-O/PE) without executing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-rehearsal workflow's smoke step executed every matrix binary directly on the runner. Cross-compiled targets can't run on the host — the rehearsal's own run failed on
aarch64-unknown-linux-gnuwithExec format error(an x86_64 ubuntu runner). macOS x86_64 passed only by luck of the current runner arch (it breaks the momentmacos-latestgoes arm64-only).The real release smokes exactly one target (release.yml's
install.shsmoke on ubuntu), so the rehearsal now mirrors that:x86_64-unknown-linux-gnu(the host-native build),od/head/tron all three runners.Verified end-to-end:
gh workflow run release-rehearsal.yml --ref fix-rehearsal-smoke→ all 6 matrix jobs + the rehearsal job green (the previous main run had the aarch64 job red).